Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash in ImageToolbox switching between Crop and Choose #1275

Open
papeh opened this issue Jul 13, 2023 · 0 comments
Open

Crash in ImageToolbox switching between Crop and Choose #1275

papeh opened this issue Jul 13, 2023 · 0 comments
Assignees
@mark-sil

Comments

@papeh
Copy link
Contributor

papeh commented Jul 13, 2023 •
edited
Loading

  • Run the Palaso WinForms Test App
  • Click Image Toolbox
  • Choose an image from a File (happens for most but not all)
  • Click Crop
  • Click Choose
  • Click Crop
    Expected: the same image is available to crop
    Actual: crash

The crash in the Palaso WinForms Test App is slightly different from the crash in FLEx (LT-21467)
papeh added a commit that referenced this issue Jul 13, 2023
@papeh
Don't throw trying to report errors
fb7db97 
Check ControlOnUIThread for null first
(this is the fancy syntax R# recommended)

Fixes the crash reported in https://jira.sil.org/browse/LT-21467
which swallows the crash reported in #1275
@papeh papeh mentioned this issue Jul 13, 2023
Merged
papeh added a commit that referenced this issue Jul 14, 2023
@papeh
Don't throw trying to report errors (#1277)
ffd8999 
Check ControlOnUIThread for null first

Fixes the crash reported in https://jira.sil.org/browse/LT-21467
which swallows the crash reported in #1275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-sil mark-sil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@papeh @mark-sil