Updates solution to build for .NET Core #59

ermshiperete · 2018-01-12T16:25:30Z

This PR replaces #37.

This change is

…tion

…gateForFunctionPointer<T>

…mpty

…ectory).

… they result in errors when PInvoking on Linux

unsupported PlatformAttribute

…contain it

method

…Library from different threads

…sion not being on .NET Core

… value for building on Linux

… and Windows

… runtime

…the TargetFrameworks have been built. (If I do it after Build, it'll try to build the package 3 times.)

…lready specified in AssemblyInfo.cs

…ixture]

…efully we can drop this in the future.

We need to check the existence of the directory before we try to look into it otherwise we get a crash. This will fix failing tests on Linux (and probably the real thing as well).

conniey added 30 commits January 12, 2018 17:17

Consolidating nuget packaging logic in icu.net.csproj

8ce5414

Updating .gitignore

2898b1f

Replacing unsupported exceptions in .NETStandard

93ed6ec

Fixing tests to assert ArgumentException rather than ApplicationExcep…

8a57f0c

…tion

Migrating Character, Collator, Locale and UnicodeSet

517b231

Add icu.net.netstandard.csproj

11c08c1

Adding SortKey support on .NET Standard

a249d47

Add icu.net.netstandard solution

0d58dae

Add OS architecture and platform detection for .NET Standard

d984e62

Fix DirectoryOfThisAssembly for .NET Standard

04b052a

Modify obsolete GetDelegateForFunctionPointer(typeof(T)) with GetDele…

2b330e9

…gateForFunctionPointer<T>

Change TestCase.Result to TestCase.ExpectedResult

a315d97

Replace Assert.IsNotNullOrEmpty -> Assert.IsNotNull and Assert.IsNotE…

85d71fa

…mpty

Replace ExpectedException(T) with Assert.Throws<T>

0fcf947

Add icu.net.netstandard.tests project

282602e

Specifying icu-dotnet as CLS-Compliant

0be00ef

Use LoadLibraryEx instead of LoadLibrary (and remove use of SetDllDir…

8a2ad29

…ectory).

Add NativeMethods.NetCore locate native assets on Windows or NetCore

529e327

NativeMethods now calls into .NET Core helper to try and get IcuVersion

591db13

Remove [MarshalAs(UnmanagedType.LPTStr] from dlopen and dlsym because…

4880d49

… they result in errors when PInvoking on Linux

Ignoring NativeMethodsTests and adding Compiler directive around

b80c2f6

unsupported PlatformAttribute

Adding test project to solution

d12e335

Add [SetCulture] and [SetUICulture] because .NUnit portable does not …

1124178

…contain it

Replacing [SetCulture] and [SetUICulture] and replacing it with helper

9b51aac

method

Adding NUnit test runner project due to nunit/dotnet-test-nunit#91

aa1e3a6

Add lock to NativeMethods class due to possibility of calling LoadIcu…

fcd2287

…Library from different threads

Hack in ability to build nuget package for .NETStandard due to GitVer…

e50a28b

…sion not being on .NET Core

Restore .NET Core solution in NuGet.targets

0581300

Add building of .NET Standard solution to icu-dotnet.proj

1fd041e

Only load GitVersion if running on MSBuild against full .NET Framework

13159be

conniey and others added 27 commits January 12, 2018 17:18

Make LoadLibraryFlags private

0089886

GetLastWin32Error after each native call to get correct error code

c88fff5

Split IcuVersionInfo into its own file

fb29a44

Collator: Fix whitespace back to tabs

f8f83ed

Fix casing for NuGet.targets for building on Linux

2af3933

Use DotNet CLI when building .NET Core projects. Fixing configuration…

94b4abc

… value for building on Linux

Assembly signing does not work on Linux in .NET Core msbuild targets

c507e16

Unify common msbuild properties: IsOnWindows and IsOnTeamCity

9001b50

Split Compile targets into 3 targets. Fix compilation calls for Linux…

3c0c7d1

… and Windows

Fix NUnit on .NET Core to run the specified configuration

835b87c

Move ExistingObjectFiles into target so it can be evaluated at Target…

ce055f5

… runtime

Consolidate all .NET Core related build properties together

b22f6b9

(FIXUP) Do nto split .net core compile into two different execs

b384088

Update to newest version of GitVersionTask

39975f0

Fix .NET Core test runs by not invoking build again

8b9e87f

Add CreateNuGetPackage target that creates a NuGet package after all …

94ecb82

…the TargetFrameworks have been built. (If I do it after Build, it'll try to build the package 3 times.)

Remove UpdateAssemblyInfo=false and individually not generate items a…

49e0f05

…lready specified in AssemblyInfo.cs

Add Platform abstraction

e6742a7

Updating NuGet packages

8343574

Fixing issues where [SetUp] and [TearDown] cannot be inside a [SetupF…

3ec9039

…ixture]

Adding compiler directives for .GetTypeInfo()

b02fac5

Adds comments to public facing methods/properties

d444b21

Updating PepitaPackage to 1.21.6

3f5d74a

Adding NUNIT2 to continue supporting NUnit 2 for legacy projects. Hop…

efe2c3e

…efully we can drop this in the future.

Updating dependencies

b31e66c

Checking for *{processorarch}* to locate native libraries

359da07

[netcore] Find finding ICU binaries

18e8331

We need to check the existence of the directory before we try to look into it otherwise we get a crash. This will fix failing tests on Linux (and probably the real thing as well).

ermshiperete merged commit 18e8331 into sillsdev:master Jan 12, 2018

ermshiperete deleted the netcore branch January 12, 2018 16:30

ermshiperete mentioned this pull request Jan 12, 2018

Updates solution to build for .NET Core #37

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates solution to build for .NET Core #59

Updates solution to build for .NET Core #59

ermshiperete commented Jan 12, 2018 •

edited

Loading

Updates solution to build for .NET Core #59

Updates solution to build for .NET Core #59

Conversation

ermshiperete commented Jan 12, 2018 • edited Loading

ermshiperete commented Jan 12, 2018 •

edited

Loading