Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libdl.dylib (not libdl.so) on Mac #191

Closed
wants to merge 3 commits into from

Conversation

imnasnainaec
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Mar 22, 2024

Test Results

       3 files  ±0     241 suites  ±0   5s ⏱️ -1s
   431 tests ±0     423 ✔️ ±0    8 💤 ±0  0 ±0 
1 309 runs  ±0  1 254 ✔️ ±0  55 💤 ±0  0 ±0 

Results for commit c283116. ± Comparison against base commit b990d03.

♻️ This comment has been updated with latest results.

@imnasnainaec imnasnainaec marked this pull request as ready for review March 25, 2024 16:12
@imnasnainaec
Copy link
Contributor Author

Tested

		private const string DLFCN_NAME = "libdl.dylib";

		[DllImport(DLFCN_NAME, EntryPoint = "dlopen", SetLastError = true)]
		private static extern IntPtr dlopen_mac(string file, int mode);

in an isolated unit test on my Mac and it didn't error.

@imnasnainaec imnasnainaec changed the title Try to get libdl functions from dlfcn.h on mac Use libdl.dylib (not libdl.so) on Mac Mar 25, 2024
Copy link
Member

@ermshiperete ermshiperete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thoughts: These changes shouldn't be necessary if the icu.net.dll.config file is in the same directory as icu.net.dll because it defines the mapping of libdl.so to libdl.dylib.

@imnasnainaec imnasnainaec marked this pull request as draft March 26, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants