Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow booleans to be 'locked' (disabled but text not greyed) #22

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

JohnThomson
Copy link
Member

@JohnThomson JohnThomson commented Apr 9, 2024

This change is Reviewable

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson)


lib/ContentPane.tsx line 899 at r1 (raw file):

      control={control}
      {...props}
      disabled = {props.disabled && !props.locked}

If I'm understanding this, it means that if we set it to disabled and locked, it won't be disabled. That seems wrong.

Copy link
Member Author

@JohnThomson JohnThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk)


lib/ContentPane.tsx line 899 at r1 (raw file):

Previously, andrew-polk wrote…

If I'm understanding this, it means that if we set it to disabled and locked, it won't be disabled. That seems wrong.

I added a comment to explain.

@andrew-polk
Copy link
Contributor

lib/ContentPane.tsx line 899 at r1 (raw file):

Previously, JohnThomson (John Thomson) wrote…

I added a comment to explain.

It isn't showing up yet

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @JohnThomson)

@andrew-polk andrew-polk merged commit c4d3afd into sillsdev:master Apr 9, 2024
1 check passed
Copy link

github-actions bot commented Apr 9, 2024

🎉 This PR is included in version 1.0.0-alpha.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants