-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow booleans to be 'locked' (disabled but text not greyed) #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @JohnThomson)
lib/ContentPane.tsx
line 899 at r1 (raw file):
control={control} {...props} disabled = {props.disabled && !props.locked}
If I'm understanding this, it means that if we set it to disabled and locked, it won't be disabled. That seems wrong.
fd7762f
to
fd1c9e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-polk)
lib/ContentPane.tsx
line 899 at r1 (raw file):
Previously, andrew-polk wrote…
If I'm understanding this, it means that if we set it to disabled and locked, it won't be disabled. That seems wrong.
I added a comment to explain.
Previously, JohnThomson (John Thomson) wrote…
It isn't showing up yet |
fd1c9e5
to
a1b7036
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @JohnThomson)
🎉 This PR is included in version 1.0.0-alpha.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This change is