-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plan Basic UI #674
Draft
davidmoore1
wants to merge
11
commits into
sillsdev:main
Choose a base branch
from
davidmoore1:feature/plan-basic-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Plan Basic UI #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmoore1
force-pushed
the
feature/plan-basic-ui
branch
from
October 24, 2024 17:56
bfd84e7
to
3475084
Compare
- added plans to the sidebar - still need an icon - tried to do the routing for plans, but I don't quite understand what I'm doing, so it's rusty, but it seems to navigate from the sidebar?
done/started: - routing that takes you to the plan detail page when you click on a plan (only works with the plans under the choose plan tab - needs work) - initial set up of the plan detail page with two tabs: info and calendar - display data/ui for the info tab - display data/ui for the calendar tab - in calendar, clicking on a day will display the refs for that day note: the detail page was designed with the assumptiion that it's an unstarted plan to do/needs work: - databses and related issues - json is only showing the first word of a string - icons for the tabs in the detail page - checkbox image for references under the calendar - styling: - width isn't right - especially noticed on the calendar tab, the css styles are not being found/applied (I also added some css styles that were from the inspection of the android to test some things, and that should be taken out) - there are no examples with multiple refs in a day, so I'm not 100% sure that part of the code works as it was untestable
- changed the <input> to <div> to allow for icons - created an InfoIcon for the info tab - used CalendarMonthIcon for the calendar tab note: it seems that the color of the icons is not being styled correctly
Included changes to convertStyles to add styles that have not been sent to PWA from SAB yet for plans
davidmoore1
force-pushed
the
feature/plan-basic-ui
branch
from
October 31, 2024 13:17
3475084
to
d9109d8
Compare
…roper locations based on the plan being active or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tab content is covered below - it is not fully completed
CSS styles are not being found/applied?
(I also added some CSS styles that were from
the inspection of the android to test some
things and that should be taken out)
day, so I'm not 100% sure that part of the code works