Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/empty docset #580

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix/empty docset #580

wants to merge 2 commits into from

Commits on May 28, 2024

  1. Return dummy docSet object for catalog 

    If catalog query fails, it most likely means there are no traditional books in the queried docSet.
Adding a dummy docSet with the appropriate docSetID, language code, and book collection ID, still allows for a catalog entry to be created such that quizzes can still be added.
    @FyreByrd
    FyreByrd committed May 28, 2024
    Configuration menu
    Copy the full SHA
    8396ad9 View commit details
    Browse the repository at this point in the history

  2. Don't write pkf file if there is no docSet 

    If a book collection does not have any traditional books, Proskomma will not have a docSet to write to a pkf file.

THIS CHANGE WILL BREAK SEVERAL THINGS
    @FyreByrd
    FyreByrd committed May 28, 2024
    Configuration menu
    Copy the full SHA
    9344904 View commit details
    Browse the repository at this point in the history