Fix quiz conversion process regarding collections #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure on this. Will probably introduce a whole host of issues with the actual app, regarding fetching data.
|
Added some changes to address some issues arising from the edge case where a docSet has no documents. |
|
Let's have two separate PRs:
I believe that I had code in SAB that would keep from building PWA without scripture books. It might be that I just checked for number of books regardless of book type (i.e. a bug). |
aidanpscott
pushed a commit
to aidanpscott/appbuilder-pwa
that referenced
this pull request
May 28, 2024
* change quiz convert from docSet to collection id * Return dummy docSet object for catalog * Don't write pkf file if there is no docSet Not sure on this. Will probably introduce a whole host of issues with the actual app, regarding fetching data. * Revert "Don't write pkf file if there is no docSet" This reverts commit cacaf54. * Revert "Return dummy docSet object for catalog" This reverts commit da35566.
This was referenced May 28, 2024
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @chrisvire 's request, switched quiz conversion to store quizzes in a folder named after the parent collection instead of the docSet.
The primary rationale is that docSet is a Proskomma specific entity, rather than one specific to an SAB project, unlike book collections.