Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade upstream SIL dependencies to 8.0.0 #1057

Merged
merged 6 commits into from
Mar 5, 2021
Merged

Conversation

johnthagen
Copy link
Collaborator

@johnthagen johnthagen commented Mar 5, 2021

Closes #471

Closes #927


This change is Reviewable

@johnthagen johnthagen added backend dependencies Pull requests that update a dependency file labels Mar 5, 2021
@johnthagen johnthagen self-assigned this Mar 5, 2021
@codecov-io

This comment has been minimized.

@johnthagen
Copy link
Collaborator Author

Going to block merging this until the next release is released successfully with #1064.

@johnthagen

This comment has been minimized.

@johnthagen johnthagen marked this pull request as ready for review March 5, 2021 21:10
@johnthagen
Copy link
Collaborator Author

I was able to test lift import and export both locally in a development configuration and within the Docker Compose project.

Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johnthagen)

@johnthagen johnthagen merged commit 63fce88 into master Mar 5, 2021
@johnthagen johnthagen deleted the sil-dependencies-8.0.0 branch March 5, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LIFT import/export fails for dev on mac Evaluate older pinned SIL Backend dependencies
3 participants