Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove user operations from mempool #98

Merged
merged 1 commit into from
Apr 1, 2023
Merged

chore: remove user operations from mempool #98

merged 1 commit into from
Apr 1, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Mar 30, 2023 •
edited
Loading

This PR does the following:

  • implements removing user operations from memool (gRPC)
  • skip waiting for transaction receipt - we can add that later, tests are running very long if we wait for receipt (and it's not needed for tests)
  • fix some gas issues when sending bundle as tx (tx reverted due to running out of gas)

@Vid201 Vid201 linked an issue Mar 30, 2023 that may be closed by this pull request
Remove user operation from mempool (gRPC endpoint) #97
Closed
@Vid201 Vid201 requested a review from zsluedem March 30, 2023 17:41
zsluedem
zsluedem approved these changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vid201 Vid201 merged commit 0711161 into main Apr 1, 2023
@Vid201 Vid201 deleted the chore/remove_uo branch April 1, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsluedem zsluedem zsluedem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove user operation from mempool (gRPC endpoint)
2 participants
@Vid201 @zsluedem