Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/codehash #87

Merged
merged 7 commits into from
Mar 29, 2023
Merged

Feat/codehash #87

merged 7 commits into from
Mar 29, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Mar 26, 2023

Check that code hashes of accessed addresses didn't changed between 1st and 2nd simulation.

@Vid201 Vid201 marked this pull request as ready for review March 27, 2023 16:35
@Vid201 Vid201 requested a review from zsluedem March 27, 2023 16:36
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

src/uopool/services/simulation.rs Show resolved Hide resolved
src/uopool/services/simulation.rs Show resolved Hide resolved
src/uopool/services/simulation.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vid201 Vid201 merged commit 07fb714 into main Mar 29, 2023
@Vid201 Vid201 deleted the feat/codehash branch March 29, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants