Fix execution revert case in estimate gas api #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsluedem
commented
Mar 25, 2023
| SimulateValidationError::UnknownError { error } => { | ||
| SimulationError::owned(SIMULATE_VALIDATION_ERROR_CODE, error, None::<bool>) | ||
| SimulationError::owned(ErrorCode::InternalError.code(), error, None::<bool>) |
There was a problem hiding this comment.
@Vid201 I am curious why unknow error belongs to SIMULATE_VALIDATION_ERROR_CODE.
There was a problem hiding this comment.
I changed that into internal error. But like your ideas on it.
Vid201
approved these changes
Mar 25, 2023
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #84
Middleware error should be all internal errors which bundler user should not know that. I remove the trait bound on the error type. Be more concrete on the error.