Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First iteration of simulate validation (user operation) #62

Merged
merged 8 commits into from
Feb 22, 2023
Merged

First iteration of simulate validation (user operation) #62

merged 8 commits into from
Feb 22, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Feb 20, 2023 •
edited
Loading

This adds first checks for simulate validation - forbidden opcodes. It also removes sanity_check_results and rertieves the stake info at the start (alongside JS trace).

@Vid201 Vid201 changed the title Draft: first iteration of simulate validation (user operation) First iteration of simulate validation (user operation) Feb 21, 2023
@Vid201 Vid201 marked this pull request as ready for review February 21, 2023 23:19
@Vid201 Vid201 requested a review from zsluedem February 21, 2023 23:20
zsluedem
zsluedem reviewed Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious what stuffs left to be resolved

src/rpc/eth.rs Outdated Show resolved Hide resolved
src/uopool/services/sanity_check.rs Show resolved Hide resolved
@Vid201
Copy link
Member Author

Vid201 commented Feb 22, 2023

I am curious what stuffs left to be resolved

You mean in general or in the simulation? For simulation, there are still several things: storage access, limitations on CALL opcodes ... I will continue with these things.

@Vid201 Vid201 requested a review from zsluedem February 22, 2023 11:13
zsluedem
zsluedem approved these changes Feb 22, 2023
View reviewed changes
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vid201 Vid201 merged commit 871e75c into main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsluedem zsluedem zsluedem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vid201 @zsluedem