Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory user operation pool #34

Merged
merged 13 commits into from
Jan 9, 2023
Merged

Memory user operation pool #34

merged 13 commits into from
Jan 9, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Jan 2, 2023

No description provided.

src/utils.rs Outdated Show resolved Hide resolved
@Vid201 Vid201 marked this pull request as ready for review January 6, 2023 11:09
@Vid201 Vid201 changed the title Draft: memory user operation pool Memory user operation pool Jan 6, 2023
@Vid201 Vid201 requested a review from zsluedem January 6, 2023 11:09
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to avoid unsafe unwrap.

src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/mod.rs Outdated Show resolved Hide resolved
src/uopool/memory.rs Outdated Show resolved Hide resolved
src/uopool/mod.rs Outdated Show resolved Hide resolved
src/uopool/mod.rs Outdated Show resolved Hide resolved
@Vid201 Vid201 requested a review from zsluedem January 6, 2023 21:46
src/uopool/mod.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great~! I would probably add additional lint for unwrap in another pr.

…unctions more generic by returning IntoIterator
@Vid201 Vid201 requested a review from zsluedem January 8, 2023 17:49
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments.

@Vid201 Vid201 merged commit d6ffc21 into main Jan 9, 2023
@Vid201 Vid201 deleted the feat/mempool branch January 9, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants