Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move hash inside user operation #276

Merged
merged 2 commits into from
Jan 17, 2024
Merged

chore: move hash inside user operation #276

merged 2 commits into from
Jan 17, 2024

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Jan 12, 2024

This PR refactors user operation structs into three structs:

  • UserOperation (hash + canonical user operation)
  • UserOperationSigned (canonical user operation)
  • UserOperationRequest (user operation with some optional fields, used for RPC estimateUserOperationGas)

@Vid201 Vid201 requested a review from zsluedem as a code owner January 12, 2024 17:35
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question

crates/grpc/src/protos/types/types.proto Outdated Show resolved Hide resolved
@Vid201
Copy link
Member Author

Vid201 commented Jan 16, 2024

@zsluedem Addressed the comment

@Vid201 Vid201 requested a review from zsluedem January 16, 2024 22:49
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zsluedem zsluedem merged commit c231383 into main Jan 17, 2024
2 checks passed
@zsluedem zsluedem deleted the chore/uo branch January 17, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants