Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial version of p2p spec #237

Merged
merged 4 commits into from
Nov 12, 2023
Merged

Initial version of p2p spec #237

merged 4 commits into from
Nov 12, 2023

Conversation

zsluedem
Copy link
Collaborator

@zsluedem zsluedem commented Nov 5, 2023

No description provided.

@zsluedem
Copy link
Collaborator Author

zsluedem commented Nov 5, 2023 

LLVM ERROR: IO failure on output stream: No space left on device
LLVM ERROR: IO failure on output stream: No space left on device

in ci

@zsluedem zsluedem requested a review from Vid201 November 6, 2023 07:50
Vid201
Vid201 reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall, GJ!

I left some comments on the first run, I will look into it again in 2/3 days

P2P.md Outdated Show resolved Hide resolved
P2P.md Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
Makefile Show resolved Hide resolved
bin/silius/src/cli/args.rs Outdated Show resolved Hide resolved
crates/p2p/src/gossipsub.rs Outdated Show resolved Hide resolved
crates/p2p/src/discovery.rs Outdated Show resolved Hide resolved
crates/p2p/src/network.rs Outdated Show resolved Hide resolved
crates/p2p/src/request_response/protocol.rs Outdated Show resolved Hide resolved
P2P.md Outdated Show resolved Hide resolved
@zsluedem zsluedem mentioned this pull request Nov 9, 2023
Open
@zsluedem zsluedem requested a review from Vid201 November 9, 2023 03:27
Vid201
Vid201 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@Vid201 Vid201 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some more comments, but otherwise LGTM 🚀

I tested and check the code, and it looks correct. We will test more when we start the actual interop testing with other bundlers

Good job, this is a big milestone!

bin/silius/src/cli/args.rs Show resolved Hide resolved
bin/silius/src/cli/args.rs Show resolved Hide resolved
crates/primitives/src/p2p.rs Show resolved Hide resolved
crates/grpc/src/uopool.rs Show resolved Hide resolved
docs/P2P.md Show resolved Hide resolved
crates/p2p/src/network.rs Outdated Show resolved Hide resolved
crates/p2p/src/request_response/behaviour.rs Outdated Show resolved Hide resolved
crates/p2p/src/network.rs Outdated Show resolved Hide resolved
crates/p2p/src/network.rs Outdated Show resolved Hide resolved
@zsluedem zsluedem merged commit ea308fc into silius-rs:main Nov 12, 2023
2 checks passed
@zsluedem zsluedem deleted the p2p branch November 12, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vid201 Vid201 Vid201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zsluedem @Vid201