Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor #139

Merged
merged 2 commits into from
Jun 7, 2023
Merged

chore: refactor #139

merged 2 commits into from
Jun 7, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented Jun 5, 2023

No new features, just refactoring. Main goal was to move some of the logic to crates where it makes more sense to have it (errors, user operation pool logic moved from grpc to uopool ...)

I also created examples folder and added one simple example.

@Vid201 Vid201 requested a review from zsluedem June 5, 2023 22:43
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very big update. Left some questions. Generally good

crates/bundler/src/bundler.rs Show resolved Hide resolved
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very big update. Left some questions. Generally good

@Vid201 Vid201 requested a review from zsluedem June 6, 2023 19:26
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vid201 Vid201 merged commit 4974f2d into main Jun 7, 2023
@Vid201 Vid201 deleted the chore/refactor branch June 7, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants