Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check time-range for user operation #123

Merged
merged 4 commits into from
May 13, 2023
Merged

feat: check time-range for user operation #123

merged 4 commits into from
May 13, 2023

Conversation

Vid201
Copy link
Member

@Vid201 Vid201 commented May 12, 2023

No description provided.

@Vid201 Vid201 requested a review from zsluedem May 12, 2023 20:37
Copy link
Collaborator

@zsluedem zsluedem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment. LGTM

@@ -20,7 +20,7 @@ aa-bundler-rpc = { path = "../../crates/rpc" }
anyhow = "1"
clap = { version = "4", features = ["derive"] }
dirs = "4.0"
ethers = { version = "2.0.1", features = ["solc-full"] }
ethers = { version = "2.0.4", features = ["solc-full"] }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://doc.rust-lang.org/cargo/reference/workspaces.html#the-dependencies-table
We could add a workspace dependency. In that case, we could only change one place in the future

@Vid201 Vid201 merged commit d57b96e into main May 13, 2023
@Vid201 Vid201 deleted the feat/timestamps branch May 13, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants