-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 11.4.1 #274
Merged
Merged
Release 11.4.1 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update version and trigger release as it didn't happen last time
## [11.4.0](v11.3.0...v11.4.0) (2024-07-07) ### Added * **searchableSelect:** add showError prop to searchableSelect and expose blur and change events ([2d4db3f](2d4db3f))
CVR-788 fix warnings
### [11.4.1](v11.4.0...v11.4.1) (2024-07-09) ### Fixed * **Card:** fix Card aria role warn ([58b599f](58b599f)) * **FileDropArea:** fix aria role warning ([d01d097](d01d097)) * **Item:** fix aria warnings in List Item ([ca3778e](ca3778e)) * **Types:** stop using deprecated svelte types ([ba4798d](ba4798d))
forevermatt
approved these changes
Jul 15, 2024
Nope, Thanks!
…On Tue, Jul 16, 2024 at 4:29 AM forevermatt ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In stories/Drawer.stories.svelte
<#274 (comment)>
:
> @@ -2,42 +2,55 @@
import { Button, Datatable, Drawer, Page } from '../components/mdc'
import { copyAndModifyArgs } from './helpers.js'
import { Meta, Template, Story } from ***@***.***/addon-svelte-csf'
-
+console.log(location)
Did you intend to leave this console.log() call here?
—
Reply to this email directly, view it on GitHub
<#274 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQ34VP6YDTVCB6MXUK3UYM3ZMQLXJAVCNFSM6AAAAABKRY2ZF2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNZYGQZDOMJUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
[image: glyph1 and logo] <https://www.sil.org> *Michael Wilson*
Web Developer
GTIS ITSE
SIL International <https://www.sil.org>
***@***.***
*M:* 319-244-8359
*O:* 0493380960
Australian Central Time
|
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
Feature branch checklist
make format
,make dry
andmake install