Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directly include expirychecker module #193

Merged
merged 8 commits into from
May 3, 2024
Merged

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Apr 15, 2024

Added

Removed

  • Removed redundant test scenarios.

Changed

  • Changed the namespace on the Validator class to avoid a custom autoload.

--

Note: the first commit is mostly just copied files, and the remainder are the changes made to those files.

@briskt briskt requested a review from a team April 15, 2024 21:20
Copy link
Contributor

@jason-jackson jason-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace could be changed to camelCase or PascalCase to increase readability, but it's fine as is too.

@briskt
Copy link
Contributor Author

briskt commented May 3, 2024

Namespace could be changed to camelCase or PascalCase to increase readability, but it's fine as is too.

I tried, but it didn't work. Maybe just needed to rename the folder as well, but I didn't want to go down that trail any further.

@briskt briskt merged commit 17a9828 into develop May 3, 2024
3 checks passed
@briskt briskt deleted the feature/expirychecker branch May 3, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants