-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.2.0 #127
Merged
Release 4.2.0 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
groundwork for new notification feature
…cation send new user notification email if enabled
…-useful Only fail Scrutinizer check for bugs/security issues.
…email check to be sure HR Contact Email is not empty
enable notifier when NOTIFIER_EMAIL_TO is not set
…ontact add new HR Contact fields in Google ID Store adapter
…dress email-service can't accept an email address with a name
Add SecureUser ID Store
briskt
approved these changes
Jan 19, 2022
forevermatt
reviewed
Jan 20, 2022
Comment on lines
+37
to
+39
/** | ||
* {@inheritdoc} | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An otherwise-empty doc. block that just contains {@inheritdoc}
can simply be left off, as good IDEs will automatically bring in the inherited docs.
forevermatt
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Fixed