Release 4.0.0 #102
Merged
Release 4.0.0 #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport Remove Insite ID Store adapter and related tests
`groupsFields` is a comma-delimited list of Workday fields used to create the 'groups' field on the ID Broker. The content of each field is converted from space-delimited to comma-delimited and merged together to form the 'groups' field.
…config new Workday groups config option
fillup
approved these changes
May 19, 2020
forevermatt
approved these changes
May 19, 2020
| $groups = []; | ||
| foreach ($groupsFields as $groupsField) { | ||
| if (strlen($user[$groupsField]) > 0) { | ||
| $groupsSubList = explode(' ', $user[$groupsField ?? '']); |
There was a problem hiding this comment.
I probably should have noticed this earlier, but why the use of ?? here?
$user[$groupsField ?? '']
Did you intend to do this instead?
$user[$groupsField] ?? ''
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
Added