Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option to enable/disable "missing email" notifications. #123

Open
briskt opened this issue Jan 12, 2022 · 0 comments
Open

Add a config option to enable/disable "missing email" notifications. #123

briskt opened this issue Jan 12, 2022 · 0 comments

Comments

@briskt
Copy link
Contributor

briskt commented Jan 12, 2022

The notifier formerly was used only for "missing email" notifications, but is now used for "new user". Only one config variable was used to enable/disable the "missing email" notification: the NOTIFIER_EMAIL_TO variable. The code in main.php just replaced the notifier with NullNotifier when no NOTIFIER_EMAIL_TO was configured. Since we now need the notifier for two kinds of messages, we can't use NullNotifier so we need another way to block the "missing email" notification. Currently, the sendMissingEmailNotice function just returns early if no NOTIFIER_EMAIL_TO is configured, but this is not as clean as it could be. Better to add a ENABLE_MISSING_EMAIL_NOTIFICATION config option when a breaking change is warranted.

@briskt briskt mentioned this issue Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant