Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加小程序获取红包封面接口 #760

Merged
merged 5 commits into from
Jan 12, 2024
Merged

Conversation

ren-jimmy
Copy link
Contributor

No description provided.

@ren-jimmy
Copy link
Contributor Author

这里格式报的什么错?没看懂

var result util.CommonError
err = json.Unmarshal(response, &result)
if err == nil && result.ErrCode != 0 {
err = fmt.Errorf("error : errcode=%v , errmsg=%v", result.ErrCode, result.ErrMsg)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议使用统一的错误处理

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的,我改一下,这个从qrcode那边复制的

@houseme
Copy link
Collaborator

houseme commented Dec 28, 2023

关联一下 issues

@ren-jimmy
Copy link
Contributor Author

解决了 #759

@ren-jimmy
Copy link
Contributor Author

通过一下

@houseme
Copy link
Collaborator

houseme commented Dec 28, 2023

通过一下

这个1.21的golangci-lint 过不了,辛苦修改一下

go-version: [ '1.16','1.17','1.18','1.19','1.20','1.21' ]

[ '1.16','1.17','1.18','1.19','1.20','1.21' ] 改为 [ '1.16','1.17','1.18','1.19','1.20','1.21.4' ]

1.21.5 和golangci 有兼容性问题,辛苦

@ren-jimmy
Copy link
Contributor Author

改了

@ren-jimmy
Copy link
Contributor Author

审批一下

Copy link
Owner

@silenceper silenceper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@silenceper silenceper merged commit 7fcd7a3 into silenceper:v2 Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants