feat: support run custom command after build succeeds #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YYCoder
force-pushed
the
feat/support_custom_cmd
branch
2 times, most recently
from
17ca9e1 to
b5c963f
Compare
YYCoder
force-pushed
the
feat/support_custom_cmd
branch
from
b5c963f to
1caefef
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under some circumstances, we need to run some custom commands after the build succeeds. For instance, we might need a shell environment to bootstrap our application, so, it does not meet our demand by run the output binary.
Support run custom command after every build succeeds, add an option
run_cmdfor YAML config to specify the command.Since we might spawn many sub-processes after running a shell command, we have to make sure that every restart must kill all the sub-processes spawned by the command to clean up. I use go-ps to list all the processes and find every descendant process spawned by the command.
Hope it would help someone ~