-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically set ip tag #20
Comments
Thank you for you proposal. It seems nice feature. Let me label this issue as a |
Hello! I'd like to work on this, but don't exactly know where to get started. I'd appreciate any guidance on the same. |
@anirudhRowjee Thank you. I think you can implement this feature like the code setting hostname tag (see below). https://github.com/sile/rustracing_jaeger/blob/master/src/reporter.rs#L152-L154 if let Ok(Ok(hostname)) = hostname::get().map(|h| h.into_string()) {
this.add_service_tag(Tag::new(constants::TRACER_HOSTNAME_TAG_KEY, hostname));
} |
Thank you for the guidance! I'm in a much better place to start now. Once again, thank you for your time! |
There's already a constant for it:
TRACER_IP_TAG_KEY
.Jaeger uses
ip
tag to group spans around individual machines for clock skew adjustment and with futures it's easy to mess up and make child spans outlive parents, triggering time travel bamboozle:It's probably best to infer
ip
tag automatically just like C++ and Go clients do.The text was updated successfully, but these errors were encountered: