Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve GitHub token handling #374

Merged
merged 3 commits into from
May 25, 2024
Merged

Conversation

siketyan
Copy link
Owner

Closes #353

GitHub integration of ghr is made on top of gh CLI, it is required to login to gh before using any GitHub related functions in ghr. In this pull request, we try to improve the error message on failed to retrieve token (see #371) and support reading token from env even if gh is not installed.

@siketyan siketyan self-assigned this May 25, 2024
@siketyan siketyan enabled auto-merge May 25, 2024 14:02
@siketyan siketyan merged commit a9e464f into main May 25, 2024
9 checks passed
@siketyan siketyan deleted the feat/error-gh-not-installed branch May 25, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support fallback to non-secure storage for GitHub OAuth tokens
1 participant