Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labelset validation in Summary #263

Closed
wants to merge 1 commit into from
Closed

Fix labelset validation in Summary #263

wants to merge 1 commit into from

Conversation

samt
Copy link

@samt samt commented May 20, 2019

See #262

@SimenB
Copy link
Collaborator

SimenB commented May 21, 2019

Thanks! Can you update the changelog and add a test? I see an old snapshot changed, so I guess we need a test for that case (wrong type) in addition to the missing label name?

siimon
siimon requested changes Jun 1, 2019
View reviewed changes
Copy link
Owner

@siimon siimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog! The code lgtm!

@zbjornson zbjornson mentioned this pull request Jan 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siimon siimon siimon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samt @SimenB @siimon