Refactor Metric type to setter

siimon · May 17, 2020 · f7f0a77 · f7f0a77
1 parent d29df0b
commit f7f0a77
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 8 deletions.
diff --git a/lib/counter.js b/lib/counter.js
@@ -9,9 +9,8 @@ const { validateLabel } = require('./validation');
 const { Metric } = require('./metric');
 
 class Counter extends Metric {
-	constructor(...args) {
-		super(...args);
-		this.type = 'counter';
+	get type() {
+		return 'counter';
 	}
 
 	/**

diff --git a/lib/gauge.js b/lib/gauge.js
@@ -16,9 +16,8 @@ const { validateLabel } = require('./validation');
 const { Metric } = require('./metric');
 
 class Gauge extends Metric {
-	constructor(...args) {
-		super(...args);
-		this.type = 'gauge';
+	get type() {
+		return 'gauge';
 	}
 
 	/**

diff --git a/lib/histogram.js b/lib/histogram.js
@@ -37,8 +37,10 @@ class Histogram extends Metric {
 				),
 			};
 		}
+	}
 
-		this.type = 'histogram';
+	get type() {
+		return 'histogram';
 	}
 
 	/**

diff --git a/lib/summary.js b/lib/summary.js
@@ -34,8 +34,10 @@ class Summary extends Metric {
 				},
 			};
 		}
+	}
 
-		this.type = 'summary';
+	get type() {
+		return 'summary';
 	}
 
 	/**
-Original file line number
+Diff line change
@@ Expand Up / @@ -37,8 +37,10 @@ class Histogram extends Metric { @@
     				),
     			};
     		}
+    	}
-    		this.type = 'histogram';
+    	get type() {
+    		return 'histogram';
     	}
     	/**
@@ Expand Down @@