Generate function without external dependencies

siimon · May 17, 2020 · 5bf5779 · 5bf5779
1 parent 8687cc7
commit 5bf5779
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 20 deletions.
diff --git a/lib/formatter.js b/lib/formatter.js
@@ -1,31 +1,32 @@
 'use strict';
 
-const generateFunction = require('generate-function');
-
 function getFormatter(metric, defaultLabels) {
 	const defaultLabelNames = Object.keys(defaultLabels);
 	const name = metric.name;
 	const help = escapeString(metric.help);
 	const type = metric.type;
 	const labelsCode = getLabelsCode(metric, defaultLabelNames, defaultLabels);
 
-	const gen = generateFunction();
-	gen(`
-  function format(item, escapeLabelValue, getValueAsString) {
-    const info = '# HELP ${name} ${help}\\n# TYPE ${name} ${type}\\n';
-    let values = '';
-    for (const val of item.values || []) {
-      val.labels = val.labels || {};
-      let metricName = val.metricName || '${name}';
-      const labels = \`${labelsCode}\`;
-      const hasLabels = labels.length > 0;
-      metricName += \`\${hasLabels ? '{' : ''}\${labels}\${hasLabels ? '}' : ''}\`;
-      let line = \`\${metricName} \${getValueAsString(val.value)}\`;
-      values += \`\${line}\\n\`;
-    }
-    return info + values;
-  }`);
-	return gen.toFunction();
+	// eslint-disable-next-line no-new-func
+	return new Function(
+		'item',
+		'escapeLabelValue',
+		'getValueAsString',
+		`
+		const info = '# HELP ${name} ${help}\\n# TYPE ${name} ${type}\\n';
+		let values = '';
+		for (const val of item.values || []) {
+		  val.labels = val.labels || {};
+		  let metricName = val.metricName || '${name}';
+		  const labels = \`${labelsCode}\`;
+		  const hasLabels = labels.length > 0;
+		  metricName += \`\${hasLabels ? '{' : ''}\${labels}\${hasLabels ? '}' : ''}\`;
+		  let line = \`\${metricName} \${getValueAsString(val.value)}\`;
+		  values += \`\${line}\\n\`;
+		}
+		return info + values;
+	  	`,
+	);
 }
 
 function getLabelsCode(metric, defaultLabelNames, defaultLabels) {

diff --git a/package.json b/package.json
@@ -45,7 +45,6 @@
 		"typescript": "^3.0.3"
 	},
 	"dependencies": {
-		"generate-function": "^2.3.1",
 		"tdigest": "^0.1.1"
 	},
 	"types": "./index.d.ts",