Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON request interface to accept base64 encoded string representing artifact hash #343

Merged
merged 6 commits into from
May 8, 2023

Conversation

malancas
Copy link
Contributor

@malancas malancas commented May 5, 2023

Summary

Update the JSON request interface to pass a base64 encoded artifactHash instead of passing a string that represents the artifact. The TSA will decode the artifact hash before doing anything else.

Release Note

Documentation

Signed-off-by: Meredith Lancaster <[email protected]>
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #343 (6aafdb2) into main (565dd4d) will increase coverage by 0.14%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##             main     #343      +/-   ##
==========================================
+ Coverage   53.11%   53.25%   +0.14%     
==========================================
  Files          20       20              
  Lines        1188     1198      +10     
==========================================
+ Hits          631      638       +7     
- Misses        496      498       +2     
- Partials       61       62       +1     
Impacted Files Coverage Δ
pkg/tests/build_test_data.go 74.28% <76.92%> (-1.72%) ⬇️

Signed-off-by: Meredith Lancaster <[email protected]>
@malancas malancas requested a review from bdehamer May 5, 2023 14:20
Signed-off-by: Meredith Lancaster <[email protected]>
@malancas malancas marked this pull request as ready for review May 5, 2023 14:55
@malancas malancas requested a review from a team as a code owner May 5, 2023 14:55
Signed-off-by: Meredith Lancaster <[email protected]>
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@malancas malancas enabled auto-merge (squash) May 8, 2023 16:38
@malancas malancas merged commit 403a0a1 into sigstore:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants