fix: require an inclusion promise when log integration time is used #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
woodruffw
commented
Dec 10, 2024
haydentherapper
approved these changes
Dec 10, 2024
woodruffw
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sigstore/protobuf-specs#442: this strengthens the inclusion promise requirement to make it mandatory when the log integration time is used as the common verification time.
This should be a non-breaking change in principle, although in practice there might be some real-world bundles that have the inclusion promises stripped from them (similar to what we saw with bundles that had inclusion proofs but no signed checkpoints). The conformance test should determine this, since it includes all CPython bundles.
Edit: conformance passes, indicating that we're OK in terms of existing bundles having inclusion promises.
CC @haydentherapper