API: make _StatementBuilder public #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
|
CC @mihaimaruseac for visibility 🙂 |
mihaimaruseac
approved these changes
Jul 31, 2024
di
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the public
StatementBuilderAPI, created by making_StatementBuilderpublic. Also adds an alternative construction route forStatement, allowing it to be directly constructed from an internal (still private)_Statement, avoiding an unnecessary serde round-trip.Note: This makes
StatementBuilderpublic, but explicitly doesn't commit it to SemVer just yet; I don't expect it to change very much, but in the event it does I don't want us locked into design decisions for the entire 3.x lifetime 🙂Closes #1076.