Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add verification policy support to client package #893

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

bdehamer
Copy link
Collaborator

@bdehamer bdehamer commented Dec 8, 2023

Updates the sigstore package to translate the input verification options into a VerificationPolicy which will be checked when the Verifier is invoked.

Includes a refactor of the verifyPolicy logic to make it more extensible if we want to support additional certificate extensions beyond the issuer in the future.

@bdehamer bdehamer requested a review from a team as a code owner December 8, 2023 18:10
Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: 83d2e61

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sigstore/verify Minor
sigstore Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bdehamer bdehamer force-pushed the bdehamer/integrate-policy branch 2 times, most recently from 16ed267 to 1e11a9f Compare December 8, 2023 18:11
@bdehamer bdehamer force-pushed the bdehamer/integrate-policy branch from 1e11a9f to 83d2e61 Compare December 8, 2023 18:15
Copy link
Contributor

@ejahnGithub ejahnGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@bdehamer bdehamer merged commit bf1d432 into main Dec 8, 2023
24 checks passed
@bdehamer bdehamer deleted the bdehamer/integrate-policy branch December 8, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants