default to generating dsse rekor entries #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f1f31d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bdehamer
commented
Oct 9, 2024
| @@ -167,6 +167,7 @@ function initWitnesses(options: SignOptions): Witness[] { | |||
| witnesses.push( | |||
| new RekorWitness({ | |||
| rekorBaseURL: options.rekorURL, | |||
| entryType: 'intoto', | |||
There was a problem hiding this comment.
Maintaining compatibility in the client package my explicitly requesting the "intoto" entry type.
bdehamer
commented
Oct 9, 2024
Comment on lines
-31
to
+33
| entryType: 'dsse' | 'intoto' = 'intoto' | ||
| entryType: 'dsse' | 'intoto' = 'dsse' |
There was a problem hiding this comment.
Switching the default from "intoto" to "dsse"
Signed-off-by: Brian DeHamer <[email protected]>
bdehamer
force-pushed
the
bdehamer/sign-default-dsse
branch
from
237a3ac to
1f1f31d
Compare
ejahnGithub
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
RekorWitnessso that it generates "dsse" entries instead of "intoto" entries by default. The user can still request an "intoto" entry by explicitly setting theentryTypefield.This is a breaking API change and will result in a major version bump.