include subject/artifactType in ECR manifest (#1058)

Signed-off-by: Brian DeHamer <[email protected]>
sigstore · Mar 8, 2024 · ee3a521 · ee3a521
1 parent d1f0f5a
commit ee3a521
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.changeset/clean-chefs-impress.md b/.changeset/clean-chefs-impress.md
@@ -0,0 +1,5 @@
+---
+"@sigstore/oci": minor
+---
+
+Include `subject` and `artifactType` fields in artifact manifest for AWS ECR
diff --git a/packages/oci/src/image.ts b/packages/oci/src/image.ts
@@ -90,20 +90,15 @@ export class OCIImage {
 
       /* istanbul ignore if */
       if (this.#downgrade) {
-        delete manifest.subject;
-        delete manifest.artifactType;
-
         // ECR can't handle media types with parameters, so we need to strip the
         // version parameter from the Sigstore bundle media type.
+        manifest.artifactType = manifest.artifactType
+          ? manifest.artifactType.replace(/;.*/, '')
+          : undefined;
         manifest.layers[0].mediaType = manifest.layers[0].mediaType.replace(
           /;.*/,
           ''
         );
-
-        // ECR can't handle the "application/vnd.oci.empty.v1+json" media type
-        // for the config blob defined in OCI 1.1, so we need to use the Docker
-        // V2 API media type
-        manifest.config.mediaType = 'application/vnd.oci.image.config.v1+json';
       }
 
       // Upload artifact manifest