Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Policy WithKey() for verifing content you know is signed with a key #235

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

steiza
Copy link
Member

@steiza steiza commented Jul 16, 2024

Summary

To address #105.

Right now, if you have a bundle signed with a key, your verification policy needs to include WithoutIdentitiesUnsafe. This isn't great though because:

  • bundles signed with keys aren't inherently unsafe
  • there isn't a way to require your bundle was signed with a key - a bundle signed with a certificate would pass WithoutIdentitiesUnsafe

Release Note

  • Added WithKey() policy option to require a bundle is signed with a key instead of a certificate

Documentation

N/A

@steiza steiza requested a review from a team July 16, 2024 19:48
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@kommendorkapten
Copy link
Member

How about adding a brief overview/example of the steps to verify with a key (creating the trusted material and configuring the policy) to the docs/verification.md, that is not covered right now.

Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@steiza steiza merged commit fef0ebe into main Jul 17, 2024
11 checks passed
@steiza steiza deleted the key-verify-policy branch July 17, 2024 14:14
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants