Dsse one sig #226
Merged
Dsse one sig #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fredrik Skogman <[email protected]>
This is a bug-fix, as the protobuf spec for the bundl requires exactly one signature to be present in the envelope. Signed-off-by: Fredrik Skogman <[email protected]>
kommendorkapten
requested review from
phillmv,
codysoyland,
haydentherapper and
steiza
Signed-off-by: Fredrik Skogman <[email protected]>
Signed-off-by: Fredrik Skogman <[email protected]>
Signed-off-by: Fredrik Skogman <[email protected]>
codysoyland
reviewed
Jul 10, 2024
codysoyland
requested changes
Jul 10, 2024
Better error name, more explicit about the usage. More explicit test caste name. Signed-off-by: Fredrik Skogman <[email protected]>
codysoyland
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #225
This is implemented by verifying that the envelope has exactly one signature during the verification process. This is a bug-fix, as the protobuf spec for the bundle requires exactly one signature to be present in the envelope.
Note that I did not chose to modify the
Signaturefunction. This could be done too, but I think it is better to have the verification process be more strict, as it is a security feature.Release Note
Documentation
N/A