Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blog post for Cosign 2.0 released #24

Merged
merged 5 commits into from
Feb 24, 2023
Merged

Add blog post for Cosign 2.0 released #24

merged 5 commits into from
Feb 24, 2023

Conversation

haydentherapper
Copy link
Contributor

Summary

Release Note

Documentation

@haydentherapper haydentherapper requested review from a team as code owners February 15, 2023 00:52
@haydentherapper
Copy link
Contributor Author

/HOLD This should not be released until the 23rd or when we release Cosign 2.0.

@haydentherapper
Add point about CosignPredicate
ca49255 
Signed-off-by: Hayden Blauzvern <[email protected]>
hectorj2f
hectorj2f previously approved these changes Feb 22, 2023
View reviewed changes
Copy link

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for doing that!

@haydentherapper
Copy link
Contributor Author

cc @bobcallaway @priyawadhwa for review

@haydentherapper
fix tag
3cf98da 
Signed-off-by: Hayden Blauzvern <[email protected]>
priyawadhwa
priyawadhwa previously approved these changes Feb 23, 2023
View reviewed changes
content/cosign-2-0-released.md Outdated Show resolved Hide resolved
@haydentherapper
Fix env var name
bad7732 
Signed-off-by: Hayden Blauzvern <[email protected]>
@johnfosborneiii
Copy link

Do you want to mention that anyone using --force/-f in cosign 1 needs to use --yes in cosign 2? I recognize that --yes was there in cosign 1 also, but in practice all the GitHub Actions I've seen were using --force which is gone. Any GitHub Action that looks like this is going to break with the transition:

  • uses: sigstore/cosign-installer@main
  • runs: cosign sign --force

@priyawadhwa priyawadhwa merged commit 34890be into sigstore:main Feb 24, 2023
@haydentherapper haydentherapper deleted the cosign2-0 branch February 24, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaikas vaikas vaikas left review comments

@priyawadhwa priyawadhwa priyawadhwa approved these changes

@bobcallaway bobcallaway bobcallaway approved these changes

@trevrosen trevrosen trevrosen approved these changes

@hectorj2f hectorj2f hectorj2f left review comments

@asraa asraa Awaiting requested review from asraa

@znewman01 znewman01 Awaiting requested review from znewman01

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@haydentherapper @johnfosborneiii @trevrosen @bobcallaway @hectorj2f @priyawadhwa @vaikas