Write the repository into secret, test air-gap mode. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaikas
force-pushed
the
air-gap
branch
3 times, most recently
from
3a5b55e
to
24e3f49
Compare
This was referenced Sep 27, 2022
vaikas
changed the title
Signed-off-by: Ville Aikas <[email protected]>
k4leung4
approved these changes
Oct 11, 2022
| @@ -203,6 +205,30 @@ jobs: | |||
| run: | | |||
| cosign verify --rekor-url ${{ env.REKOR_URL }} --allow-insecure-registry ${{ env.demoimage }} | |||
|
|
|||
| # Test with cosign in 'airgapped mode' | |||
| # Uncomment these once modified cosign goes in. | |||
There was a problem hiding this comment.
do we have a commit or version we should look for?
There was a problem hiding this comment.
I'll grab the version after it gets committed. I tested with my own fork for functionality, but will need to update the instructions, documentation, so will do after it's been released. Is that ok?
There was a problem hiding this comment.
Sorry, I'll grab the 'release' once it gets released with my commit there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ville Aikas [email protected]
Summary
TUF server now writes the compressed repo to a secret along with 1.root.json. This way we can test things like air-gap modes, especially in policy-controller without env variables.
Add a test simulating air-gap mode where we bring in a filesystem based TUF repository.
Was tested with:
https://github.com/sigstore/cosign/compare/main...vaikas:cosign:air-gap?expand=1
But I uncommented it for now so we can get this in and then I can add cosign e2e tests there as well once
we cut a release here.
Release Note
Documentation