buiding a new body for conflict reponses #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javan lacerda <[email protected]>
javanlacerda
commented
Apr 18, 2024
cmd/prober/write.go
Outdated
| return fmt.Errorf("rekor entry: %w", err) | ||
| resp, t, err := makeRekorRequest(cert, priv, hostPath) | ||
| // A new body should be created when it is conflicted | ||
| for resp.StatusCode == http.StatusConflict { |
There was a problem hiding this comment.
Does it make sense it be in a while? Or should I set a number of attempts ?
Signed-off-by: Javan lacerda <[email protected]>
haydentherapper
requested changes
Apr 23, 2024
cmd/prober/write.go
Outdated
| } | ||
| defer resp.Body.Close() | ||
| } | ||
| latency := time.Since(t).Milliseconds() |
There was a problem hiding this comment.
Can we record latency and response data for each request to Rekor? This would measure the total time for all requests.
There was a problem hiding this comment.
You mean we should also record the responses that has StatusConflict?
cmd/prober/write.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("error adding entry: %w", err) | ||
| } | ||
| defer resp.Body.Close() | ||
| // A new body should be created when it is conflicted | ||
| for { |
There was a problem hiding this comment.
Can we put a reasonable limit, let's say 10, on this loop?
cmd/prober/write.go
Outdated
| t := time.Now() | ||
| resp, err := retryableClient.Do(req) | ||
| latency := time.Since(t).Milliseconds() | ||
| resp, t, err := makeRekorRequest(cert, priv, hostPath) |
There was a problem hiding this comment.
Can we move this into the for loop?
cmd/prober/write.go
Outdated
|
|
||
| t = time.Now() | ||
| resp, err := retryableClient.Do(req) | ||
| return resp, t, err |
There was a problem hiding this comment.
I'd suggest returning the latency calculation latency := time.Since(t).Milliseconds() rather than the time object.
Signed-off-by: Javan lacerda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #900
Summary
It adds retries updating the body for Rekor writing requests when the response has 409 code. It means that the body has conflict, then we should create a new/different body for the request.
Release Note
Documentation