Allow sharding config to be written in yaml or json #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now we only support yaml, which is getting annoying with Helm (Helm has a bunch of issues trying to parse it). Signed-off-by: Priya Wadhwa <[email protected]>
dlorenc
approved these changes
Aug 15, 2022
dsa0x
reviewed
Aug 16, 2022
| @@ -82,6 +83,10 @@ func logRangesFromPath(path string) (Ranges, error) { | |||
| return Ranges{}, nil | |||
| } | |||
| if err := yaml.Unmarshal(contents, &ranges); err != nil { | |||
| // Try to use JSON | |||
| if jerr := json.Unmarshal(contents, &ranges); jerr == nil { | |||
| return ranges, nil | |||
There was a problem hiding this comment.
If we don't assign this jerr to err, there can be a situation where we have a nil error, but a zero-value range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we only support yaml, which is getting annoying with Helm (Helm has a bunch of issues trying to parse it).
Signed-off-by: Priya Wadhwa [email protected]
Summary
Release Note
Documentation