-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for intersection
& union
in search operations
#968
Conversation
Signed-off-by: Samsondeen Dare <[email protected]>
Signed-off-by: Samsondeen Dare <[email protected]>
944d14f
to
befb72d
Compare
Signed-off-by: Samsondeen Dare <[email protected]>
e64a153
to
ed6c9e3
Compare
Codecov Report
@@ Coverage Diff @@
## main #968 +/- ##
==========================================
- Coverage 48.15% 40.93% -7.23%
==========================================
Files 61 69 +8
Lines 5401 6491 +1090
==========================================
+ Hits 2601 2657 +56
- Misses 2520 3551 +1031
- Partials 280 283 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Samsondeen Dare <[email protected]>
Signed-off-by: Samsondeen Dare <[email protected]>
Oh wow, this is really cool! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Quick question on correctness/expectation here.
and
& or
operations
Signed-off-by: Samsondeen Dare <[email protected]>
d99c7c3
to
12b38af
Compare
Signed-off-by: Samsondeen Dare <[email protected]>
357442c
to
ec6f3e5
Compare
Signed-off-by: Samsondeen Dare <[email protected]>
and
& or
operationsintersection
& union
in search operations
Signed-off-by: Samsondeen Dare <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks amazing now! Great work. Good job on the unit tests and testing in e2e.
The implementation was very cool to read.
Summary
This PR addresses this enhancement issue #849, which suggested adding support for intersection and union search. The PR adds support for
and
andor
operators.and
operation returns a union of values in each list (i.e no duplicates)or
returns a list of all values, not minding duplicates.Release Note
new: support for intersection and union search through the use of
and
andor
operators.Documentation