-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop application/yaml content type #933
Conversation
This is a breaking change for any clients that are currently requesting application/yaml. This is the simplest fix to sigstore#593, as openapi randomly switches between json and yaml responses when no content type is provided. Fixes sigstore#593 Signed-off-by: Hayden Blauzvern <[email protected]>
Looks like there is a difference between how the comments are generated. This should be ok. |
hey 👋 when i open a PR there was a dependabot that making unnecessary commit automatically i have mo idea about that please help me i am stuck |
I think there's one additional thing in the Makefile that needs addressed: |
@Ansari-Danish please open a separate issue instead of discussing on an unrelated PR. Thanks! |
Signed-off-by: Hayden Blauzvern <[email protected]>
@bobcallaway Updated the Makefile. Any advice on how to handle the client differences due to the comment? Can we just ignore the required check when merging? |
Codecov Report
@@ Coverage Diff @@
## main #933 +/- ##
==========================================
+ Coverage 48.20% 48.35% +0.15%
==========================================
Files 62 61 -1
Lines 5398 5383 -15
==========================================
+ Hits 2602 2603 +1
+ Misses 2513 2500 -13
+ Partials 283 280 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@bobcallaway Ran |
Signed-off-by: Hayden Blauzvern <[email protected]>
Figured it out, I was using go 1.19 and not .18. |
* Drop application/yaml content type This is a breaking change for any clients that are currently requesting application/yaml. This is the simplest fix to sigstore#593, as openapi randomly switches between json and yaml responses when no content type is provided. Fixes sigstore#593 Signed-off-by: Hayden Blauzvern <[email protected]> * remove default-consumes from Makefile Signed-off-by: Hayden Blauzvern <[email protected]> * Fix comment generation Signed-off-by: Hayden Blauzvern <[email protected]>
This is a breaking change for any clients that are currently requesting
application/yaml.
This is the simplest fix to #593, as openapi randomly switches between
json and yaml responses when no content type is provided.
Fixes #593
Signed-off-by: Hayden Blauzvern [email protected]
Summary
Release Note
Dropped support for YAML content type
Documentation