Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on the release job/makefile cleanup #914

Merged
merged 2 commits into from
Jul 9, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jul 9, 2022

Summary

  • using go1.18 we dont need to pass some ldflags anymore, the only one is the git tag which there is an open issues in the go library for that (dont recall the number, but will find it)
  • clean up of the makefile and update cosign image

Documentation

n/a

@cpanato cpanato requested a review from a team as a code owner July 9, 2022 09:48
@codecov-commenter
Copy link

Codecov Report

Merging #914 (ae2c948) into main (25dbcf5) will decrease coverage by 0.14%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #914      +/-   ##
==========================================
- Coverage   48.25%   48.11%   -0.15%     
==========================================
  Files          62       62              
  Lines        5398     5398              
==========================================
- Hits         2605     2597       -8     
- Misses       2511     2517       +6     
- Partials      282      284       +2     
Impacted Files Coverage Δ
pkg/types/alpine/v0.0.1/entry.go 54.20% <0.00%> (-2.53%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 48.82% <0.00%> (-0.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25dbcf5...ae2c948. Read the comment docs.

@dlorenc dlorenc merged commit c962a68 into sigstore:main Jul 9, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Jul 9, 2022
@cpanato cpanato deleted the updates-release branch July 10, 2022 11:20
bobcallaway pushed a commit to bobcallaway/rekor that referenced this pull request Aug 3, 2022
* remove not needed ldflags

Signed-off-by: cpanato <[email protected]>

* update variable name and cosign image

Signed-off-by: cpanato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants