Remove unnecessary lookup of non-existent attestations from storage layer #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only two Rekor pluggable types support the storage of attestations (intoto, cose); the previous code to fetch attestations was type-agnostic, but due to the fix sigstore#878 the server was doing unnecessary lookups for all types, regardless of whether they store attestation content or not. This makes the attestation storage an explict interface, which we can test casting for and avoid a roundtrip to the storage layer for types that don't support storing attestations. Signed-off-by: Bob Callaway <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #909 +/- ##
==========================================
+ Coverage 47.84% 48.12% +0.28%
==========================================
Files 62 62
Lines 5459 5427 -32
==========================================
Hits 2612 2612
+ Misses 2559 2527 -32
Partials 288 288
Continue to review full report at Codecov.
|
|
Oooh nice! |
dlorenc
approved these changes
Jul 6, 2022
priyawadhwa
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only two Rekor pluggable types support the storage of attestations (
intoto,cose); the previous code to fetch attestations was type-agnostic, but due to the fix #878, the server was doing unnecessary lookups for all types, regardless of whether they store attestation content or not.This makes the attestation storage an explicit interface, which we can test casting for and avoid a round trip to the storage layer for types that don't support storing attestations.
Signed-off-by: Bob Callaway [email protected]