Fix intoto index keys #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure we include all appropriate index keys including: - entire DSSE envelope SHA256 digest - envelope (base64 decoded) SHA256 digest - entire X509 signing certificate - any relevant keys extracted from X509 signing certificate Fixes: sigstore#872 Signed-off-by: Bob Callaway <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #889 +/- ##
==========================================
+ Coverage 46.99% 47.60% +0.60%
==========================================
Files 62 62
Lines 5413 5432 +19
==========================================
+ Hits 2544 2586 +42
+ Misses 2587 2558 -29
- Partials 282 288 +6
Continue to review full report at Codecov.
|
dlorenc
previously approved these changes
Jun 28, 2022
asraa
previously approved these changes
Jun 28, 2022
Signed-off-by: Bob Callaway <[email protected]>
asraa
previously approved these changes
Jun 28, 2022
Signed-off-by: Bob Callaway <[email protected]>
asraa
reviewed
Jun 28, 2022
Signed-off-by: Bob Callaway <[email protected]>
dlorenc
approved these changes
Jun 29, 2022
|
cc @cpanato we should cut a release after this goes in I think |
|
Ok @dlorenc will prepare the changelog and check if need other updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure we include all appropriate index keys including:
Fixes: #890
Fixes: #876
Signed-off-by: Bob Callaway [email protected]