Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in configmap to release for sharding config #766

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Apr 8, 2022

Eventually when we shard, we just have to update the config map with sharding details.

Right now it's just empty and shouldn't change functionality at all. Tested locally and it looks good.

ref #711

cc @lkatalin

Signed-off-by: Priya Wadhwa [email protected]

Summary

Ticket Link

Fixes

Release Note


@priyawadhwa priyawadhwa requested a review from a team as a code owner April 8, 2022 23:47
@codecov-commenter
Copy link

Codecov Report

Merging #766 (30a1320) into main (4dabcda) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #766      +/-   ##
==========================================
- Coverage   48.95%   48.91%   -0.04%     
==========================================
  Files          61       61              
  Lines        5585     5589       +4     
==========================================
  Hits         2734     2734              
- Misses       2556     2559       +3     
- Partials      295      296       +1     
Impacted Files Coverage Δ
pkg/sharding/ranges.go 50.58% <0.00%> (-2.50%) ⬇️
pkg/types/alpine/v0.0.1/entry.go 61.24% <0.00%> (-0.78%) ⬇️
pkg/types/rekord/v0.0.1/entry.go 51.51% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dabcda...30a1320. Read the comment docs.

@dlorenc dlorenc merged commit 1727fae into sigstore:main Apr 11, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants