Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rekor-cli loginfo #734

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Conversation

priyawadhwa
Copy link
Contributor

@priyawadhwa priyawadhwa commented Mar 15, 2022

This refactors the loginfo file in preparation for also getting info for inactive shards and verifying them as well.

It just breaks up the logic into a few smaller functions:

  • verifyTree -- currently verifies only the active log, but it'll be easy to pass in treeID later to verify a specific log
  • loadVerifier -- currently just gets the public key, but separating this out will make it easier to get the public key for a specific log later
  • proveConsistency -- proves consistency between stored state and current state of the log

Signed-off-by: Priya Wadhwa [email protected]

@priyawadhwa priyawadhwa requested a review from a team as a code owner March 15, 2022 12:22
This refactors the loginfo file in preparation for also getting info for inactive shards and verifying them as well.

Signed-off-by: Priya Wadhwa <[email protected]>
@lkatalin
Copy link
Contributor

Thanks, this is a good idea. If I'm reading this correctly, we will also be able to use this to verify each shard/tree in a logRangeMap passed in by the user as a next step?

@priyawadhwa
Copy link
Contributor Author

If I'm reading this correctly, we will also be able to use this to verify each shard/tree in a logRangeMap passed in by the user as a next step?

yup, exactly!

@dlorenc dlorenc merged commit ebc1d7a into sigstore:main Mar 16, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 16, 2022
@priyawadhwa priyawadhwa deleted the refactor-loginfo branch March 17, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants