Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearer logging for createAndInitTree #724

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Conversation

priyawadhwa
Copy link
Contributor

ref #711

Signed-off-by: Priya Wadhwa [email protected]

Summary

Ticket Link

Fixes

Release Note


@priyawadhwa priyawadhwa requested a review from a team as a code owner March 10, 2022 13:29
@codecov-commenter
Copy link

Codecov Report

Merging #724 (72512b5) into main (982ebd7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   47.56%   47.58%   +0.01%     
==========================================
  Files          65       65              
  Lines        5670     5670              
==========================================
+ Hits         2697     2698       +1     
  Misses       2683     2683              
+ Partials      290      289       -1     
Impacted Files Coverage Δ
pkg/types/rekord/v0.0.1/entry.go 50.90% <0.00%> (-0.61%) ⬇️
pkg/types/alpine/v0.0.1/entry.go 62.40% <0.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 982ebd7...72512b5. Read the comment docs.

Copy link
Contributor

@lkatalin lkatalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, thanks @priyawadhwa

@dlorenc dlorenc merged commit a7ea462 into sigstore:main Mar 10, 2022
@github-actions github-actions bot added this to the v1.0.0 milestone Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants