Implement /api/v1/version for rekor-server #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Let's see if GitHub is working again... |
|
The only discussion point I believe is if the different LDFLAGS values really belong under |
I don't mind much either way. The new |
This implements a version endpoint for rekor. This helps figure out the
version the server is currently running. It could later be used to
implement version compatibility with CLI utilities.
Example:
λ rekor main» curl -s localhost:3000/api/v1/version | jq
{
"builddate": "'2021-12-27T13:20:32Z'",
"commit": "12d1a47c7ac986932a2734cb855c642ac01ffde4",
"treestate": "dirty",
"version": "v0.4.0-15-g12d1a47-dirty"
}
This removes some duplication of the build flags and inserts them into
/pkg/api which is then reused across the utilities.
Signed-off-by: Morten Linderud <[email protected]>
Signed-off-by: Morten Linderud <[email protected]>
Signed-off-by: Morten Linderud <[email protected]>
Foxboron
force-pushed
the
morten/version
branch
from
fc046c4
to
cfe0837
Compare
|
Fixed the missing license header. I can squash the commit with the generated swagger stuff if it's needed. |
dlorenc
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements
/api/v1/versionand allows us to properly check what versionrekor-serveris currently running on a deployed instance.Ticket Link
Fixes
Release Note